[VT]: Add a way to track VT float attributes #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad3154
added
enhancement
ad3154
force-pushed
the
adrian/vt-float-attributes
branch
2 times, most recently
from
38a6923 to
4c83485
Compare
|
GwnDaan
reviewed
Nov 8, 2024
isobus/include/isobus/isobus/isobus_virtual_terminal_client_update_helper.hpp
Show resolved
Hide resolved
GwnDaan
force-pushed
the
adrian/vt-float-attributes
branch
from
4c83485 to
3a866f2
Compare
GwnDaan
force-pushed
the
adrian/vt-float-attributes
branch
from
fe1c646 to
edb3675
Compare
This lets you use the VT state helper to deal with float attributes. Previously, float values may not have been handled correctly.
…eed messages and fixed incorrect formatting specifiers in `isobus_virtual_terminal_client_update_helper.cpp`
GwnDaan
force-pushed
the
adrian/vt-float-attributes
branch
from
edb3675 to
cd0961d
Compare
|
GwnDaan
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This lets you use the VT state helper to deal with float attributes. Previously, float values were probably not handled correctly.
I was seeing that there were warnings in the seeder example about this:
How has this been tested?